Typing () returns wrong set of signatures (textDocument/signatureHelp)

[yyoncho]

  public void testB() {
    if (|)
  }

when the cursor in on | I think that the server returns all methods that are in the current scope(class).

[fbricon]

Same behavior in Eclipse IDE. Note that true/false are also proposed.
I could understand returning non-void methods, as you can make a boolean statement out of any method call that returns something, but even the void methods are returned here. So it looks like a JDT bug. Need to check/open for a matching ticket in JDT.

[fbricon]

Same behavior in Intellij IDEA, so it might be done on purpose after all

[fbricon]

IntelliJ IDEA also has a smart completion mode where only items matching the expected type are returned. Which would be nice to have too. See https://www.jetbrains.com/help/idea/auto-completing-code.html#smart_completion

[yyoncho]

@fbricon signatureHelp is not intended to suggest methods no matter whether they are matching or not but it should describe the function call at the point. So in this case, the server should return empty set since () does not stand for function invocation.

[fbricon]

mmmok I didn't realize you were talking about signatureHelp ;-)

[yyoncho]

Yep, I fixed the title.

[fbricon]

I can reproduce the problem. Indeed it doesn't make sense to return methods here.