Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature Help doesn't correctly detect the active signature #1017

Closed
fbricon opened this issue Apr 30, 2019 · 0 comments · Fixed by #1020
Closed

Signature Help doesn't correctly detect the active signature #1017

fbricon opened this issue Apr 30, 2019 · 0 comments · Fixed by #1020

Comments

@fbricon
Copy link
Contributor

fbricon commented Apr 30, 2019

When calling the signatureHelp feature on an existing method call (Trigger Parameter hint command in vscode), the wrong signature is selected initially. Here the cursor is on "a":

Screen Shot 2019-04-30 at 2 29 03 PM

Currently, the server returns the 1st method that has a matching parameter at the cursor position. Instead, it should identify the current method from the offset, then match signatures that match that invocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants