Suppress "Unsupported SuppressWarning" warnings by default. #1062
Labels
Milestone
Comments
|
@NikolasKomonen can you please look into this one? |
NikolasKomonen
added a commit
to NikolasKomonen/eclipse.jdt.ls
that referenced
this issue
Aug 26, 2019
Fixes eclipse-jdtls#1062 This PR simply sets the preference to 'Ignore', in the case that someone wants the option to turn it back on another PR will be needed to create a preference Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
fbricon
pushed a commit
that referenced
this issue
Sep 2, 2019
Fixes #1062 This PR simply sets the preference to 'Ignore', in the case that someone wants the option to turn it back on another PR will be needed to create a preference Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We notice this specifically in VS Code, where we have a lot of
SuppressWarningattributes set for PMD and Checkstyle variables. This causes the eclipse engine to actually spit out more warnings about not knowing what these suppressions are. This seems kind of backwards, where adding a suppression actually creates a warning, and causes a lot of confusion with our users.I reported it for VS Code at redhat-developer/vscode-java#507 but I feel like the warning itself should be suppressed at the language server level by default, as its totally backwards in whats actually being warned about.
The text was updated successfully, but these errors were encountered: