Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 3.16 semantic tokens #1678

Closed
yyoncho opened this issue Mar 5, 2021 · 1 comment · Fixed by #1806
Closed

Support 3.16 semantic tokens #1678

yyoncho opened this issue Mar 5, 2021 · 1 comment · Fixed by #1806

Comments

@yyoncho
Copy link
Contributor

yyoncho commented Mar 5, 2021

I noticed that the latest version of the server has semantic tokens implementation but it is not following the 3.16 spec. It will be nice to do so in order to have that functionality in other clients without the need for additional client-side code.

@0dinD
Copy link
Contributor

0dinD commented Mar 14, 2021

I agree, this would be ideal. The work on the current semantic tokens implementation started before it was standardized in LSP, and that's why it's using a custom command, used in the semantic tokens provider of the VS Code extension. Implementing it via LSP instead would also provide benefits in the VS Code extension, such as being able to provide semantic tokens in lightweight mode (where custom commands are disabled).

I don't have time to work on it right now, but if no one else does I'll probably have time in a few weeks. Implementing it should just be a matter of upgrading LSP libraries (if needed), and moving the semantic token commands from JDTDelegateCommandHandler to the correct place in the LSP implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants