Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java.settings.url does not override default java settings #1741

Closed
rgrunber opened this issue Apr 23, 2021 · 0 comments · Fixed by #1744
Closed

java.settings.url does not override default java settings #1741

rgrunber opened this issue Apr 23, 2021 · 0 comments · Fixed by #1744
Assignees

Comments

@rgrunber
Copy link
Contributor

rgrunber commented Apr 23, 2021

Test.java

import java.io.Serializable;
public class Test implements Serializable {
    public void test () {
    }
}

/home/user/Scripts/org.eclipse.jdt.core.prefs (set as java.settings.url)

org.eclipse.jdt.core.compiler.problem.missingSerialVersion=error
org.eclipse.jdt.core.compiler.problem.missingJavadocComments=error
org.eclipse.jdt.core.compiler.problem.missingJavadocTags=error

On initial load, only the javadoc errors are displayed. The missingSerialVersion error is ignored (which is now the default since 0019109 ). https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/StandardProjectsManager.java#L262 seems to be overriding correctly, so not exactly sure where it's going wrong.

It seems to work if the settings file is project specific (.settings/org.eclipse.jdt.core.prefs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants