Completion no longer shows sensible candidates in else branches

[mfussenegger]

On latest master (f4fad03)
Completion candidates in the else branches started to be useless, see this short demo:

recording.mp4

This is in the https://github.com/crate/crate codebase: https://github.com/crate/crate/blob/master/server/src/main/java/io/crate/protocols/postgres/PostgresWireProtocol.java#L645 in case you need something to reproduce. (I haven't yet tried to see if this happens on smaller projects)

If I checkout the commit before 9c41c18 everything is good again.

[fbricon]

That's bad. @snjeza please investigate

[rgrunber]

I can reproduce with Eclipse 2021-06 (RC2) (I20210603-0040) + latest buildship. Looks like an upstream regression sometime between M1 (I20210407-1800) and RC2 M3 (I20210519-1800).

[rgrunber]

I'm able to reproduce with a simpler snippet :

Test.java

public class Test {
    private void test() {
        Foo foo;
        Object need;
        if (true) {
        } else {
            foo.
            need = null;
        }
    }
}

Foo.java

public class Foo {
    public void foo1() {}
    public void foo2() {}
    public class Bar {}
}

It looks like if the local identifier (eg. foo) matches (case insensitive) a type (eg. Foo), it is interpreted as that type and only shows type (or static?) completions.

[snjeza]

The following code doesn't work too:

private void test(String s, int i) {
  if (i > 2) {
  } else {
    s.|
    System.out.println("b");
}

[snjeza]

I have created https://bugs.eclipse.org/bugs/show_bug.cgi?id=574215

[rgrunber]

The fix for this should be in an I-build from the end of today (17th) at http://download.eclipse.org/eclipse/downloads/ . The next milestone build to include this will be for 4.21 M1 (July 16th).

@fbricon , given that we're close to doing a release, does it make sense to use the current 4.20 Release as the target platform and temporarily copy CompletionEngine locally to include the fix ? Or would you rather immediately have a bug fix release that adopts the new I-build ?

[testforstephen]

Since completion is a high frequency feature, i'd like use I-build to include the fix. Once 4.21 M1 is out, then replace the target platform with it.

[fbricon]

+1 to releasing from an I-Build, until a more stable version is available

[snjeza]

We already use 4.21-I-builds/I20210606-1800/ - https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target#L34
I will update it when a new build is released.

[fbricon]

Looks like completion is still broken in the latest master:

public void name(String fooo) {
    if (fooo != null) {
      fo| <-fooo is not proposed here
      System.err.println("Done");
    }
}

[rgrunber]

Thanks Fred, for https://bugs.eclipse.org/bugs/show_bug.cgi?id=574338 . Corresponding build should be there by end of today.

[niko-liu]

bug still exists in M1

[rgrunber]

@niko-liu Can you confirm this is still an issue on I20210726-1800 (http://download.eclipse.org/eclipse/downloads/drops4/I20210726-1800/). This seems to be what we're currently using. It could be possible that there's additional cases not being handled correctly.

[niko-liu]

@niko-liu Can you confirm this is still an issue on I20210726-1800 (http://download.eclipse.org/eclipse/downloads/drops4/I20210726-1800/). This seems to be what we're currently using. It could be possible that there's additional cases not being handled correctly.

I20210726-1800 has fixed it ,thx