CI failed

[Eskibear]

See https://ci.eclipse.org/ls/job/jdt-ls-pr/2807/ and recent PR builds.

mostly failed cases.

org.eclipse.jdt.ls.core.internal.handlers.CodeActionResolveHandlerTest.testResolveCodeAction_AnnotationQuickFixes
org.eclipse.jdt.ls.core.internal.commands.ProjectCommandTest.testGetClasspathsForMavenWhenUpdating
org.eclipse.jdt.ls.core.internal.commands.ProjectCommandTest.testGetClasspathsForMaven
org.eclipse.jdt.ls.core.internal.handlers.AdvancedOrganizeImportsHandlerTest.testDuplicateStaticImports
org.eclipse.jdt.ls.core.internal.handlers.ResolveSourceMappingHandlerTest.testResolveDependencyUri
org.eclipse.jdt.ls.core.internal.handlers.WorkspaceSymbolHandlerTest.testEmptyNames
org.eclipse.jdt.ls.core.internal.javadoc.JavaDocImageExtractionTest.testImageExtractionWithSourceJar
org.eclipse.jdt.ls.core.internal.managers.MavenBuildSupportTest.testDownloadSources
org.eclipse.jdt.ls.core.internal.managers.MavenBuildSupportTest.testUpdateSnapshots
org.eclipse.jdt.ls.core.internal.managers.MavenProjectImporterTest.testAnnotationProcessing

[rgrunber]

This doesn't seem to be consistent : https://ci.eclipse.org/ls/job/jdt-ls-master/ (1157 & 1158 are succeeding).

[snjeza]

@rgrunber See https://ci.eclipse.org/ls/job/jdt-ls-pr/

[Eskibear]

I did observe random failing of PR builds, and I'm curious about what can be the culprit...

Also see:
#1806 (comment)
#1842 (comment) (it's working now after manually retriggering)

[Eskibear]

https://ci.eclipse.org/ls/job/jdt-ls-pr/2823/console

11:15:46 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:2.3.0:test (default-test) on project org.eclipse.jdt.ls.tests: An unexpected error occurred while launching the test runtime (process returned error code 137(SIGKILL received?)).

seems to be killed after running for 10 min?

[Eskibear]

New case of failure:

https://ci.eclipse.org/ls/job/jdt-ls-pr/2838/testReport/org.eclipse.jdt.ls.core.internal.handlers/DocumentLifeCycleHandlerTest/testUnimplementedMethods/

Stacktrace
org.mockito.exceptions.misusing.WrongTypeOfReturnValue: 

Preferences$$EnhancerByMockitoWithCGLIB$$a5cb28e1 cannot be returned by getClientPreferences()
getClientPreferences() should return ClientPreferences
***
If you're unsure why you're getting above error read on.
Due to the nature of the syntax above problem might occur because:
1. This exception *might* occur in wrongly written multi-threaded tests.
   Please refer to Mockito FAQ on limitations of concurrency testing.
2. A spy is stubbed using when(spy.foo()).then() syntax. It is safer to stub spies - 
   - with doReturn|Throw() family of methods. More in javadocs for Mockito.spy() method.

	at org.eclipse.jdt.ls.core.internal.handlers.DocumentLifeCycleHandlerTest.mockPreferences(DocumentLifeCycleHandlerTest.java:198)
	at org.eclipse.jdt.ls.core.internal.handlers.DocumentLifeCycleHandlerTest.setup(DocumentLifeCycleHandlerTest.java:101)