Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable m2e Java configurator for compilerIds {jdt,eclipse,javac-with-errorprone} #196

Closed
fbricon opened this issue Mar 27, 2017 · 2 comments
Closed

Enable m2e Java configurator for compilerIds {jdt,eclipse,javac-with-errorprone} #196

fbricon opened this issue Mar 27, 2017 · 2 comments
Assignees
@fbricon
Labels
enhancement maven
Milestone
Late March 2017

Comments

@fbricon
Copy link
Contributor

fbricon commented Mar 27, 2017

Non standard compilerIds for the maven-compiler-plugin are unknown to m2e and thus require a specific lifecycle mapping to enable Java support in Eclipse (see m2e-jdt-compiler)

I think we should, rather than embed new bundles (m2e-jdt-compiler and another for google's error-prone), simply embed our own default lifecycle-mapping-metadata.xml (for commonly used maven plugins)
@gorkem
Copy link
Contributor

gorkem commented Mar 27, 2017

What is the reason for avoiding the m2e-jdt-compiler plugin? It looks like it only provides the lifecycle-mapping-metadata.xml file and nothing else.

fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Mar 27, 2017
@fbricon
Support other Maven compilerIds. Fixes eclipse-jdtls#196
bb9bd1e 
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon self-assigned this Mar 27, 2017
@fbricon fbricon added this to the Late March 2017 milestone Mar 27, 2017
@fbricon
Copy link
Contributor Author

fbricon commented Mar 27, 2017

  • it's an external bundle, we'll need to CQ it
  • it's not gonna change
  • it's an extra bundle to load into the OSGi platform, it's really not worth it.
  • combining and embedding all extra lifecycle mappings into our own plugin is simple and efficient

fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Mar 27, 2017
@fbricon
Support other Maven compilerIds. Fixes eclipse-jdtls#196
e45bb57 
supports the following compilerIds:

- jdt
- eclipse
- javac-with-errorprone

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Mar 27, 2017
@fbricon
Support other Maven compilerIds. Fixes eclipse-jdtls#196
8e1e272 
supports the following compilerIds:

- jdt
- eclipse
- javac-with-errorprone

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit that referenced this issue May 17, 2017
@fbricon
Update m2e to latest oxygen M7 stable release
190d632 
as a consequence, lifecycle mappings for non standard maven compilerIds can be removed.
Effectively reverting changes for #196

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@gdoenlen gdoenlen mentioned this issue Feb 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbricon fbricon

Labels
enhancement maven
Projects
None yet
Milestone
Late March 2017
Development

No branches or pull requests
2 participants
@gorkem @fbricon