Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support LAMBDA_EXPRESSION in completion #1985

Closed
Eskibear opened this issue Jan 6, 2022 · 4 comments · Fixed by #1990
Closed

support LAMBDA_EXPRESSION in completion #1985

Eskibear opened this issue Jan 6, 2022 · 4 comments · Fixed by #1990

Comments

@Eskibear
Copy link
Contributor

Eskibear commented Jan 6, 2022

Originally reported in redhat-developer/vscode-java#2253 (comment)

CompletionProp1osal.LAMBDA_EXPRESSION has been introduced in jdt.core v3.28, but we failed to construct corresponding completionItem. It goes into below code branch.

https://github.com/eclipse/eclipse.jdt.ls/blob/7ffff9d6b1c95f06261eac998210861cd5f63286/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/contentassist/CompletionProposalDescriptionProvider.java#L686-L688

@Eskibear

This comment has been minimized.

@Eskibear
Copy link
Contributor Author

Eskibear commented Jan 7, 2022

In eclipse, it completes for something like ${1:t} -> ${0}:

lambda.mp4

@0dinD
Copy link
Contributor

0dinD commented Jan 14, 2022

I like the way it's done in Eclipse, snippets with tabstops are very convenient.

@Eskibear
Copy link
Contributor Author

A demo here, i'll create corresponding PR later.

lambda-vscode.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants