Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The project preference should only persist non default values #2272

Closed
jdneo opened this issue Oct 17, 2022 · 0 comments · Fixed by #2274
Closed

The project preference should only persist non default values #2272

jdneo opened this issue Oct 17, 2022 · 0 comments · Fixed by #2274
Assignees

Comments

@jdneo
Copy link
Contributor

jdneo commented Oct 17, 2022

The code https://github.com/eclipse/eclipse.jdt.ls/blob/f6af5170ea2f63dd2864ab2e73beb84154163b98/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/Preferences.java#L2051 sets the whole set of the Java Core options to the project preferences file, which introduce a side effect that in the future when we want to change a value in the global preferences, it will not take effect since the project level preference will always override it.

We should only persist the key-values which are not equal to the default ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants