Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: initiate progress reporting using the window/workDoneProgress/create request #2377

Closed
LDAP opened this issue Dec 18, 2022 · 2 comments · Fixed by #2707
Closed

LSP: initiate progress reporting using the window/workDoneProgress/create request #2377

LDAP opened this issue Dec 18, 2022 · 2 comments · Fixed by #2707

Comments

@LDAP
Copy link

LDAP commented Dec 18, 2022

According to the LSP Specification#initiatingWorkDoneProgress the server must initiate progress reporting using the window/workDoneProgress/create request. The token provided in the create request should then only be used once.

Currently, jdtls sends $/progress notifications with kind begin without initiating progress reporting first:

:: <-  jdtls $/progress: {'token': '0ed628a5-8838-45bd-896e-65c0deda3dc7', 'value': {'kind': 'begin', 'title': 'Refreshing Maven model', 'message': 'Refreshing Maven model'}}
:: <-  jdtls $/progress: {'token': '0ed628a5-8838-45bd-896e-65c0deda3dc7', 'value': {'kind': 'report', 'percentage': 0, 'message': 'Refreshing Maven model'}}
:: <-  jdtls $/progress: {'token': '0ed628a5-8838-45bd-896e-65c0deda3dc7', 'value': {'kind': 'report', 'percentage': 0, 'message': 'Refreshing Maven model'}}
:: <-  jdtls $/progress: {'token': '0ed628a5-8838-45bd-896e-65c0deda3dc7', 'value': {'kind': 'end', 'message': 'Updating Maven Dependencies'}}
:: <-  jdtls $/progress: {'token': '0ed628a5-8838-45bd-896e-65c0deda3dc7', 'value': {'kind': 'begin', 'title': 'project test_a0aa8f63', 'message': 'Updating Maven Dependencies'}}
:: <-  jdtls $/progress: {'token': '0ed628a5-8838-45bd-896e-65c0deda3dc7', 'value': {'kind': 'end', 'message': 'Updating Maven Dependencies'}}

See: sublimelsp/LSP-jdtls#37

@rgrunber
Copy link
Contributor

rgrunber commented Mar 27, 2023

This might be something for @jasonhy-wang to look into. For some context, this would be a continuation of #2258 . See https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workDoneProgress for full details.

@hopehadfield
Copy link
Contributor

I'm interested in working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants