Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement labelDetails for CompletionItem #2476

Closed
rgrunber opened this issue Feb 17, 2023 · 1 comment · Fixed by #2556
Closed

Implement labelDetails for CompletionItem #2476

rgrunber opened this issue Feb 17, 2023 · 1 comment · Fixed by #2556

Comments

@rgrunber
Copy link
Contributor

This depends on #2348 (LSP >= 3.17)

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionItemLabelDetails

When returning a list completion items, we set the label to contain a lot of information :

{
  "label": "getLogger(String arg0, ResourceBundle arg1) : Logger",
  "kind": 2,
  "detail": "System.getLogger(String arg0, ResourceBundle arg1) : Logger" 
...
...

It looks like the type signature information, as well as fully qualified names / file paths could be rendered more elegantly if we use this new property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants