Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting NullPointerException in signatureHelp/codeAction/inlayHint requests when AST is not generated. #2608

Closed
ajaydeopa opened this issue Apr 19, 2023 · 4 comments · Fixed by #2612
Closed

Getting NullPointerException in signatureHelp/codeAction/inlayHint requests when AST is not generated. #2608

ajaydeopa opened this issue Apr 19, 2023 · 4 comments · Fixed by #2612
Labels
bug code-actions completion semantic highlighting signature help
Milestone
End April 2023

Comments

@ajaydeopa
Copy link

Issue

When there is a bug in user's code because of which AST can't be generated, then all the textDocument/signatureHelp requests are throwing NullPointerException

How to reproduce

  1. Copy the code in editor 
    class Test {
    public static void main(string[] args) {
        
    }

    static void fun() {
        int a
        for (l < 10) {

        }
    }
}
  2. Trigger textDocument/signatureHelp request.

Stack Trace

java.util.concurrent.CompletionException: java.lang.NullPointerException: Cannot invoke "org.eclipse.jdt.core.dom.ASTNode.accept(org.eclipse.jdt.core.dom.ASTVisitor)" because "root" is null
	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315)
	at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320)
	at java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:649)
	at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482)
	at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.NullPointerException: Cannot invoke "org.eclipse.jdt.core.dom.ASTNode.accept(org.eclipse.jdt.core.dom.ASTVisitor)" because "root" is null
	at org.eclipse.jdt.core.dom.NodeFinder.<init>(NodeFinder.java:196)
	at org.eclipse.jdt.core.dom.NodeFinder.perform(NodeFinder.java:105)
	at org.eclipse.jdt.ls.core.internal.handlers.SignatureHelpHandler.getNode(SignatureHelpHandler.java:291)
	at org.eclipse.jdt.ls.core.internal.handlers.SignatureHelpHandler.signatureHelp(SignatureHelpHandler.java:89)
	at org.eclipse.jdt.ls.core.internal.handlers.JDTLanguageServer.lambda$8(JDTLanguageServer.java:600)
	at org.eclipse.jdt.ls.core.internal.BaseJDTLanguageServer.lambda$0(BaseJDTLanguageServer.java:75)
	at java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:646)
	... 2 more
@fbricon fbricon changed the title Getting NullPointerException in textDocument/signatureHelp request when AST is not generated. Getting NullPointerException in signatureHelp/codeAction/inlayHint requests when AST is not generated. Apr 19, 2023
@fbricon
Copy link
Contributor

fbricon commented Apr 19, 2023 •
edited
Loading

Also triggers exceptions during inlayHint request:

java.lang.IllegalArgumentException
	at org.eclipse.jdt.core.dom.InfixExpression.setOperator(InfixExpression.java:383)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1287)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:2047)
	at org.eclipse.jdt.core.dom.ASTConverter.convertToParenthesizedExpression(ASTConverter.java:3919)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1953)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1204)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1990)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:3161)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:751)
	at org.eclipse.jdt.core.dom.ASTConverter.buildBodyDeclarations(ASTConverter.java:208)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:3456)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1534)
	at org.eclipse.jdt.core.dom.CompilationUnitResolver.convert(CompilationUnitResolver.java:344)
	at org.eclipse.jdt.core.dom.ASTParser.internalCreateAST(ASTParser.java:1272)
	at org.eclipse.jdt.core.dom.ASTParser.createAST(ASTParser.java:868)
	at org.eclipse.jdt.core.manipulation.CoreASTProvider$1.run(CoreASTProvider.java:294)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)
	at org.eclipse.jdt.core.manipulation.CoreASTProvider.createAST(CoreASTProvider.java:286)
	at org.eclipse.jdt.core.manipulation.CoreASTProvider.getAST(CoreASTProvider.java:199)
	at org.eclipse.jdt.ls.core.internal.handlers.InlayHintsHandler.inlayHint(InlayHintsHandler.java:59)

codeAction request:

java.lang.IllegalArgumentException
	at org.eclipse.jdt.core.dom.InfixExpression.setOperator(InfixExpression.java:383)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1287)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:2047)
	at org.eclipse.jdt.core.dom.ASTConverter.convertToParenthesizedExpression(ASTConverter.java:3919)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1953)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1204)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1990)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:3161)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:751)
	at org.eclipse.jdt.core.dom.ASTConverter.buildBodyDeclarations(ASTConverter.java:208)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:3456)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1534)
	at org.eclipse.jdt.core.dom.CompilationUnitResolver.convert(CompilationUnitResolver.java:344)
	at org.eclipse.jdt.core.dom.ASTParser.internalCreateAST(ASTParser.java:1272)
	at org.eclipse.jdt.core.dom.ASTParser.createAST(ASTParser.java:868)
	at org.eclipse.jdt.core.manipulation.CoreASTProvider$1.run(CoreASTProvider.java:294)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)
	at org.eclipse.jdt.core.manipulation.CoreASTProvider.createAST(CoreASTProvider.java:286)
	at org.eclipse.jdt.core.manipulation.CoreASTProvider.getAST(CoreASTProvider.java:199)
	at org.eclipse.jdt.core.manipulation.CoreASTProvider.getAST(CoreASTProvider.java:189)
	at org.eclipse.jdt.ls.core.internal.handlers.CodeActionHandler.getASTRoot(CodeActionHandler.java:340)
	at org.eclipse.jdt.ls.core.internal.handlers.CodeActionHandler.getCodeActionCommands(CodeActionHandler.java:129)

semanticHighlighting request:

java.lang.IllegalArgumentException
	at org.eclipse.jdt.core.dom.InfixExpression.setOperator(InfixExpression.java:383)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1287)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:2047)
	at org.eclipse.jdt.core.dom.ASTConverter.convertToParenthesizedExpression(ASTConverter.java:3919)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1953)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1204)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1990)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:3161)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:751)
	at org.eclipse.jdt.core.dom.ASTConverter.buildBodyDeclarations(ASTConverter.java:208)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:3456)
	at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1534)
	at org.eclipse.jdt.core.dom.CompilationUnitResolver.convert(CompilationUnitResolver.java:344)
	at org.eclipse.jdt.core.dom.ASTParser.internalCreateAST(ASTParser.java:1272)
	at org.eclipse.jdt.core.dom.ASTParser.createAST(ASTParser.java:868)
	at org.eclipse.jdt.core.manipulation.CoreASTProvider$1.run(CoreASTProvider.java:294)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)
	at org.eclipse.jdt.core.manipulation.CoreASTProvider.createAST(CoreASTProvider.java:286)
	at org.eclipse.jdt.core.manipulation.CoreASTProvider.getAST(CoreASTProvider.java:199)
	at org.eclipse.jdt.ls.core.internal.handlers.SemanticTokensHandler.full(SemanticTokensHandler.java:46)

@fbricon
Copy link
Contributor

fbricon commented Apr 19, 2023

Similar error when performing completion

@fbricon
Copy link
Contributor

fbricon commented Apr 19, 2023

Basically, all calls to CoreASTProvider.getAST should be wrapped into a safer higher level method, throughout the codebase.

@fbricon fbricon mentioned this issue Apr 20, 2023
Merged
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Apr 20, 2023
@fbricon
Prevent various NPEs due to invalid AST
c2c68bc 
Added guards where needed whenever CoreASTProvider.getAST() is called.
Fixes eclipse-jdtls#2608 and silences various errors logged when AST creation fails.
Also see: eclipse-jdt/eclipse.jdt.core#317

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon added this to the End April 2023 milestone Apr 20, 2023
@fbricon
Copy link
Contributor

fbricon commented Apr 20, 2023

So all those "IllegalArgumentException at org.eclipse.jdt.core.dom.InfixExpression.setOperator(InfixExpression.java:383)" are just polluting the logs, but are not crashes.
The NPE during SignatureHelp was caused by CoreASTProvider.getInstance().getAST() returning null (after logging the IllegalArgumentException). #2612 adds null-checks in all places where they were missing. Also adds a dirty hack to silence the chatty stacktraces logged by CoreASTProvider.

fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Apr 21, 2023
@fbricon
Prevent various NPEs due to invalid AST
1ea8c73 
Added guards where needed whenever CoreASTProvider.getAST() is called.
Fixes eclipse-jdtls#2608 and silences various errors logged when AST creation fails.
Also see: eclipse-jdt/eclipse.jdt.core#317

Signed-off-by: Fred Bricon <fbricon@gmail.com>
rgrunber pushed a commit that referenced this issue Apr 21, 2023
@fbricon @rgrunber
Prevent various NPEs due to invalid AST
eda8081 
Added guards where needed whenever CoreASTProvider.getAST() is called.
Fixes #2608 and silences various errors logged when AST creation fails.
Also see: eclipse-jdt/eclipse.jdt.core#317

Signed-off-by: Fred Bricon <fbricon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug code-actions completion semantic highlighting signature help
Projects
None yet
Milestone
End April 2023
Development

Successfully merging a pull request may close this issue.

Prevent various NPEs due to invalid AST fbricon/eclipse.jdt.ls
3 participants
@fbricon @jdneo @ajaydeopa