Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SymbolKind.Function returned for Method #422

Closed
tsmaeder opened this issue Nov 10, 2017 · 2 comments
Closed

SymbolKind.Function returned for Method #422

tsmaeder opened this issue Nov 10, 2017 · 2 comments
Assignees
@snjeza
Labels
bug
Milestone
End November 2017

Comments

@tsmaeder
Copy link
Contributor

The method DocumentSymbolHandler#mapKind() returns "SymbolKind.Function" when for a Java method.
My expectation is that it would return SymbolKind.Method.
@tsmaeder tsmaeder added the bug label Nov 10, 2017
@fbricon
Copy link
Contributor

fbricon commented Nov 10, 2017

@gorkem SymbolKind.Method has been there since the 1st release of lsp4j, any particular reason why it was not used, or is it a simple oversight?
Method and Function symbols are identical in vscode, so changing won't be an issue there. Hopefully other clients won't be affected either when we change it.

@fbricon fbricon added this to the End November 2017 milestone Nov 10, 2017
@gorkem
Copy link
Contributor

gorkem commented Nov 10, 2017

Yes, it is an oversight. I think we can change it.

@snjeza snjeza mentioned this issue Nov 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snjeza snjeza

Labels
bug
Projects
None yet
Milestone
End November 2017
Development

No branches or pull requests
4 participants
@gorkem @fbricon @snjeza @tsmaeder