Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocompletion in main source proposes test classes #526

Closed
fbricon opened this issue Jan 25, 2018 · 1 comment
Closed

Autocompletion in main source proposes test classes #526

fbricon opened this issue Jan 25, 2018 · 1 comment
Assignees
@fbricon @snjeza
Labels
bug
Milestone
End January 2018

Comments

@fbricon
Copy link
Contributor

fbricon commented Jan 25, 2018 •
edited

After moving jdt.core to latest photon bits (see #527), where test classpath is isolated from main classpath, Test classes are still proposed in autocompletion, while editing a main class. Once the class is saved, the test imports are validated as errors
@fbricon fbricon added the bug label Jan 25, 2018
@fbricon fbricon mentioned this issue Jan 25, 2018
Closed
@fbricon
Copy link
Contributor Author

fbricon commented Jan 25, 2018

Found filtering code upstream : http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=90dbec1ca3a0198af184c40ae0d2a321b7d5ec3c

@fbricon fbricon added this to the End January 2018 milestone Jan 25, 2018
@fbricon fbricon self-assigned this Jan 25, 2018
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Jan 25, 2018
@fbricon
Handle test visibility in completion proposals. Fixes eclipse-jdtls#526
19da60a 
Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Jan 26, 2018
@fbricon
Handle test visibility in completion proposals. Fixes eclipse-jdtls#526
c458e3c 
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon mentioned this issue Jan 26, 2018
Closed
@snjeza snjeza mentioned this issue Jan 26, 2018
Merged
tsmaeder pushed a commit to bdshadow/eclipse.jdt.ls that referenced this issue Apr 6, 2018
@fbricon @tsmaeder
Handle test visibility in completion proposals. Fixes eclipse-jdtls#526
8588800 
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbricon fbricon

@snjeza snjeza

Labels
bug
Projects
None yet
Milestone
End January 2018
Development

No branches or pull requests
2 participants
@fbricon @snjeza