Add code action to generate toString() method

[fbricon]

No description provided.

[testforstephen]

@fbricon Same as hashCode and equals method, the implementation class GenerateToStringOperation in org.eclipse.jdt.ui needs move to org.eclipse.jdt.core.manipulation.

[fbricon]

cc @rgrunber and @jjohnstn

[jjohnstn]

Working on it

[jjohnstn]

Gerrit patch submitted: https://git.eclipse.org/r/134075

[jjohnstn]

Patch has been accepted to jdt.ui/jdt.core.manipulation. This can be closed.

[fbricon]

@jjohnstn we still need to make changes on the jdt.ls side, to call the new code

[jjohnstn]

@fbricon yes, my bad.

[fbricon]

@yaohaizh can you work on this one for the next release or should I assign it to someone else?

[yaohaizh]

@fbricon Sure, I'll follow this issue on this release.

[testforstephen]

The upstream GenerateToStringOperation.java implementation puts "generate the text edit" and "apply the text edit" steps together. But eclipse.jdt.ls only needs the first step and return a text edit to vscode client to apply.

In order to reuse this part of code, we may need more refactoring on this class. GenerateHashCodeEqualsOperation.java is a good reference.
-> Give the apply control to the external caller.
-> Expose a getter method to return the TextEdit change.

cc: @fbricon @jjohnstn

[testforstephen]

@jjohnstn I'd like to submit a PR to the upstream code, but not familiar with the contribution process. Is there any doc to explain the PR and environment setup process for eclipse.jdt.ui code? thanks.

[jjohnstn]

Hi Jinbo, eclipse.jdt.ui uses gerrit, not github so you need to do a patch and submit it via gerrit. For details on submitting to Eclipse via gerrit, see: https://wiki.eclipse.org/Gerrit For eclipse.jdt.ui, your patch must apply to the latest patch on the master branch. If you are attempting to edit/test inside an Eclipse workspace, you will need eclipse.jdt.core, eclipse.platform.text and possibly eclipse.jdt.debug, eclipse.jdt, and eclipse.platform.text checked out to have latest and greatest. All of those are also in git repos which you can find via google. Let me know if you have further questions after reading the web-page.

…

-- Jeff J.

On Mon, Mar 4, 2019 at 4:08 AM Jinbo Wang ***@***.***> wrote: @jjohnstn <https://github.com/jjohnstn> I'd like to submit a PR to the upstream code, but not familiar with the contribution process. Is there any doc to explain the PR and environment setup process for eclipse.jdt.ui code? thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#736 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKRbYuGU_0umdOEPjuNX4ucy76Oq_njks5vTOKmgaJpZM4ViCCr> .

[testforstephen]

@jjohnstn Thanks for the information. Having a try. Will update the status if everything goes well.

[testforstephen]

@jjohnstn i have one question about the testing. In addition to unit test, how can i manually verify my change locally?

[testforstephen]

Tried "Debug as Eclipse Application", the new change is hit.

[testforstephen]

Submitted a gerrit patch https://git.eclipse.org/r/#/c/138149/. But the build failed at an irrelevant test case. I tried rerun the failed case locally and it passed.

@jjohnstn Is there any way to rerun the ci job for gerrit patch?

[jjohnstn]

You can't rerun unless you are a comitter (it is annoying). The ways to do this are either to wait until another patch is committed and then rebase or else make a small change (e.g. change a comment) and update the gerrit patch (keeping the same changeid).

[testforstephen]

Got that. Roland has helped re-trigger the build. Thanks.

[rgrunber]

The changed was merged (targeting 4.12 M1) but should also be in the next I-build of JDT.

[testforstephen]

@rgrunber Great, thanks. Will try to finish the change on jdt.ls side.

[fbricon]

@testforstephen so I'll target this one for the next release. Let me know if we need to punt it to the next one

[testforstephen]

i should have time to do it in next week.