Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[theia/java] getting language/actionableNotification for each gradle file in workspace #768

Closed
AlexTugarev opened this issue Aug 27, 2018 · 5 comments

Comments

@AlexTugarev
Copy link

In Theia, each language/actionableNotification is translated to a user notification. But if you try to open a project in workspace which has many gradle files, this strategy seems to be really spammy.

I compared with vscode, and LS tracing confirms this behavior; getting 75 notifications for a spring boot project. Though they manage to debounce the noise.

Is it intended to let the client debounce these notifications? What's you're recommendation?

@fbricon
Copy link
Contributor

fbricon commented Aug 27, 2018

It should not be spammy, ideally. Do you have a sample project reproducing this 75 notifications issue?

@AlexTugarev
Copy link
Author

git clone https://github.com/spring-projects/spring-boot, which is ok in vscode due to some magic, but I see the notification in tracing:

screen shot 2018-08-27 at 15 04 42

try with Theia it will show you all of them at once.

@fbricon
Copy link
Contributor

fbricon commented Aug 27, 2018

ok, so the 1st thing to do would be for jdt.ls to ignore changed build files under the build folder, it should stop the spam at once

@AlexTugarev
Copy link
Author

now you mentioned it, as far as I see, all of them are in bin folders.

ok, even if you would take care of that, would you suggest to debounce actionableNotifications?

@fbricon
Copy link
Contributor

fbricon commented Aug 27, 2018

@AlexTugarev only if they're identical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants