Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a proposal for convert local variable to field #772

Closed
svor opened this issue Aug 28, 2018 · 7 comments · Fixed by #1088
Closed

Add a proposal for convert local variable to field #772

svor opened this issue Aug 28, 2018 · 7 comments · Fixed by #1088
Assignees
@testforstephen
Labels
code-actions enhancement
Milestone
Mid July 2019

Comments

@svor
Copy link
Contributor

svor commented Aug 28, 2018 •
edited

Handle the following cases in QuickAssistProcessor:

getConvertLocalToFieldProposal(context, coveringNode, resultingCollections);
@svor
Copy link
Contributor Author

svor commented Aug 28, 2018 •
edited

Need to port org.eclipse.jdt.internal.corext.refactoring.code.PromoteTempToFieldRefactoring and maybe some related classes from jdt.ui

@fbricon
Copy link
Contributor

fbricon commented Aug 28, 2018

cc @jjohnstn @rgrunber

@jjohnstn
Copy link
Contributor

PromoteTempToFieldRefactoring has a dependency on CodeGeneration and StubUtility both of which are not approved yet.

@testforstephen testforstephen self-assigned this Jun 27, 2019
@testforstephen testforstephen mentioned this issue Jun 27, 2019
Closed
@testforstephen
Copy link
Contributor

Created a gerrit patch to refactor PromoteTempToFieldRefactoring to jdt.core.manipulation.
https://git.eclipse.org/r/#/c/145079/

cc @jjohnstn @rgrunber

@jjohnstn
Copy link
Contributor

I have left comments in the gerrit review.

@testforstephen
Copy link
Contributor

@jjohnstn thanks for the review, updated the gerrit patch.

@jjohnstn
Copy link
Contributor

jjohnstn commented Jul 2, 2019

Patch has been merged, thx for the update.

@testforstephen testforstephen mentioned this issue Jul 3, 2019
Merged
@testforstephen testforstephen added this to the Mid July 2019 milestone Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@testforstephen testforstephen

Labels
code-actions enhancement
Projects
None yet
Milestone
Mid July 2019
Development

Successfully merging a pull request may close this issue.

Refactoring: Extract to Field testforstephen/eclipse.jdt.ls
4 participants
@fbricon @jjohnstn @svor @testforstephen