Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server returns code actions even when no changes are generated #894

Closed
fbricon opened this issue Dec 10, 2018 · 0 comments
Closed

Server returns code actions even when no changes are generated #894

fbricon opened this issue Dec 10, 2018 · 0 comments
Assignees
@fbricon
Labels
code-actions enhancement
Milestone
Mid December 2018

Comments

@fbricon
Copy link
Contributor

fbricon commented Dec 10, 2018

When requesting the source actions, Organize imports is always returned, even if there's no change associated with the workspace edit. Also applies to Getters/Setters in #892.

No code action should be returned if it doesn't do anything.
@fbricon fbricon self-assigned this Dec 10, 2018
@fbricon fbricon mentioned this issue Dec 10, 2018
Merged
@fbricon fbricon changed the title Server returns source actions even when no changes are generated Server returns code actions even when no changes are generated Dec 10, 2018
@fbricon fbricon added this to the Mid December 2018 milestone Dec 10, 2018
@fbricon fbricon mentioned this issue Dec 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbricon fbricon

Labels
code-actions enhancement
Projects
None yet
Milestone
Mid December 2018
Development

No branches or pull requests
1 participant
@fbricon