Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file system watchers in vscode-java #926

Closed
yyoncho opened this issue Jan 29, 2019 · 2 comments
Closed

file system watchers in vscode-java #926

yyoncho opened this issue Jan 29, 2019 · 2 comments
Assignees

Comments

@yyoncho
Copy link
Contributor

yyoncho commented Jan 29, 2019

At this point vscode-java register the following watches:

workspace.createFileSystemWatcher('/*.java'),
workspace.createFileSystemWatcher('
/pom.xml'),
workspace.createFileSystemWatcher('/*.gradle'),
workspace.createFileSystemWatcher('
/.project'),
workspace.createFileSystemWatcher('/.classpath'),
workspace.createFileSystemWatcher('
/settings/*.prefs'),
workspace.createFileSystemWatcher('/src/')

It seems to me that these watchers must be established by as a result of "workspace/didChangeWatchedFiles". Please correct me if I mistaken.

@fbricon
Copy link
Contributor

fbricon commented Jan 30, 2019

if you mean dynamically register those watchers after importing the projects, then yes, that would make sense

@fbricon fbricon self-assigned this Feb 8, 2019
@fbricon fbricon added this to the Mid February 2019 milestone Feb 8, 2019
@fbricon fbricon removed this from the Mid February 2019 milestone Feb 20, 2019
@fbricon fbricon added this to the Mid April 2019 milestone Apr 11, 2019
@fbricon
Copy link
Contributor

fbricon commented Apr 11, 2019

Fixed with #981

@fbricon fbricon closed this as completed Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants