Workaround for corrupted tasklist command #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
reviewed
Mar 1, 2019
| @@ -77,6 +77,11 @@ private boolean parentProcessStillRunning() { | |||
| process.destroy(); | |||
| finished = process.waitFor(POLL_DELAY_SECS, TimeUnit.SECONDS); // wait for the process to stop | |||
| } | |||
| if (Platform.OS_WIN32.equals(Platform.getOS()) && finished && process.exitValue() > 1) { | |||
| // the tasklist command should return 0 (parent process exists) or 1 (parent process doesn't exist) | |||
| JavaLanguageServerPlugin.logInfo("The tasklist command: '" + command + "' returns " + process.exitValue()); | |||
There was a problem hiding this comment.
Last time I tried logging anything in that method, it would "activate" the server, making it wait another 30sec before the next polling
There was a problem hiding this comment.
You can test using the following patch:
diff --git a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/ParentProcessWatcher.java b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/ParentProcessWatcher.java
index 597d24e6..6ab798c7 100644
--- a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/ParentProcessWatcher.java
+++ b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/ParentProcessWatcher.java
@@ -64,7 +64,7 @@ public final class ParentProcessWatcher implements Runnable, Function<MessageCon
}
String command;
if (Platform.OS_WIN32.equals(Platform.getOS())) {
- command = "cmd /c \"tasklist /FI \"PID eq " + pid + "\" | findstr " + pid + "\"";
+ command = "cmd /c \"tasklist2 /FI \"PID eq " + pid + "\" | findstr " + pid + "\"";
} else {
command = "ps -p " + pid;
}
|
L47, add : LOGGER.warning("Parent process stopped running, forcing server exit");
|
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
|
@fbricon I have updated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#815
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com