Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Maven project imports to reduce memory consumption #982

Closed
fbricon opened this issue Apr 4, 2019 · 0 comments · Fixed by #999
Closed

Batch Maven project imports to reduce memory consumption #982

fbricon opened this issue Apr 4, 2019 · 0 comments · Fixed by #999

Comments

@fbricon
Copy link
Contributor

fbricon commented Apr 4, 2019

As described in #824 (comment), the Maven project import mechanism could be optimized in the following ways:

9 - The maven importer imports all projects in one step - https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/MavenProjectImporter.java#L153. In this way, Java LS requires a lot of memory. The che project contains 299 maven projects. VS Code 0.42.0 requires 2g of heap when importing it using an empty maven local repository. I have added the following feature:

if a workspace contains more than ten projects, Java LS imports ten projects in one step and updates the workspace after importing all the projects.
This feature enables us to import the che project with 1g of heap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants