Prevent aggressive classpath updates when jars don't change #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheng Chen <sheche@microsoft.com>
|
Indeed this is the proper comparison method. Do you have a reference to a bug this is fixing? Unit test would be a plus too. |
|
@fbricon I just found this issue when I was reading the codes. From my understanding, always executing Should I file an issue for this PR as a reference? |
|
No it's ok. |
fbricon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sheng Chen sheche@microsoft.com
It seems that here the
Arrays.equals()is intended to be used, since the original condition in the if-block will always return true.