Support Diagnostic Tag #1161
Merged
Support Diagnostic Tag #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaroml
commented
Sep 4, 2019
|
eclipse-lsp4j/lsp4j#362 was merged. And the change to LSP4J is official now. Please proceed with this one. @testforstephen @fbricon @snjeza |
fbricon
reviewed
Sep 6, 2019
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/DiagnosticsHandler.java
Outdated
Show resolved
Hide resolved
|
eclipse-lsp4j/lsp4j#366 was sent to apply the protocol change regarding capabilities. |
|
The build failure will recover once the change to LSP4J is merged. |
|
test this please |
fbricon
requested changes
Sep 13, 2019
...e.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/WorkspaceDiagnosticsHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rome Li <rome.li@microsoft.com>
Signed-off-by: Rome Li <rome.li@microsoft.com>
Signed-off-by: Rome Li <rome.li@microsoft.com>
Signed-off-by: Rome Li <rome.li@microsoft.com>
akaroml
force-pushed
the
diagnostic-tag
branch
from
fe069b1
to
840a5b9
Compare
|
The build failures do not seem like caused by this PR... #1183 is tracking this. |
|
test this please |
testforstephen
approved these changes
Sep 25, 2019
|
Thanks @akaroml ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rome Li rome.li@microsoft.com
Fix #1162
And it looks like this when it's running:
