Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dup call of getRawLocationURI() #1299

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

Eskibear
Copy link
Contributor

@Eskibear Eskibear commented Dec 6, 2019

Screen Shot 2019-12-06 at 12 44 25 PM

Above is profiled by JProfiler when I complete for letter 'S'. According to the result, getRawLocationURI() is not cheap. This PR should improve the perf a little bit.

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@fbricon fbricon added this to the Mid December 2019 milestone Dec 6, 2019
@fbricon fbricon merged commit ef55688 into eclipse-jdtls:master Dec 6, 2019
@fbricon
Copy link
Contributor

fbricon commented Dec 6, 2019

Nice catch @Eskibear!

@Eskibear Eskibear deleted the remove-dup-call branch December 9, 2019 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants