Intellisense does not work when attached javadoc can't be read #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
requested changes
Dec 25, 2019
|
@fbricon I have updated the PR. |
fbricon
requested changes
Dec 27, 2019
| @@ -0,0 +1,176 @@ | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
There was a problem hiding this comment.
the build, reporting and profiles sections are not necessary
testforstephen
requested changes
Dec 27, 2019
| @@ -2563,6 +2565,28 @@ public void testCompletion_FilterTypesKeepMethods() throws JavaModelException { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| public void testCompletion_InvalidJavadoc() throws Exception { | |||
| importProjects("maven/aspose"); | |||
There was a problem hiding this comment.
Can we make the project folder name to be consistent with the artifact id aspose-word-test in the pom.xml?
| IProject project = null; | ||
| ICompilationUnit unit = null; | ||
| try { | ||
| project = ResourcesPlugin.getWorkspace().getRoot().getProject("aspose-word-test"); |
There was a problem hiding this comment.
-> WorkspaceHelper.getProject("aspose-word-test")
| return element.getAttachedJavadoc(null); | ||
| String attachedJavadoc; | ||
| try { | ||
| attachedJavadoc = element.getAttachedJavadoc(null); |
There was a problem hiding this comment.
return element.getAttachedJavadoc(null);
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
testforstephen
approved these changes
Dec 31, 2019
fbricon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#1217
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com