Expose proposals for 3rd-party extensions #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Eskibear
force-pushed
the
expose-proposals
branch
from
749f450
to
8479186
Compare
|
As this PR
Can you take a look and see if we can get it shipped with the coming release? |
yaohaizh
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a first step for redhat-developer/vscode-java#1257
This PR enables IntelliCode to fetch the whole completion item list, it
1 ) adds the getter of
proposals.2) moves calculation of replacement texts into method
toCompletionItem.