Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix launch configs: use com.ibm.icu #1365

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Conversation

Eskibear
Copy link
Contributor

replace com.ibm.icu.base with com.ibm.icu, otherwise below error occurs:

!ENTRY org.eclipse.jdt.core 4 0 2020-02-26 16:01:31.083
!MESSAGE FrameworkEvent ERROR
!STACK 0
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.jdt.core [455]
  Unresolved requirement: Require-Bundle: org.eclipse.team.core; bundle-version="[3.1.0,4.0.0)"; resolution:="optional"
  Unresolved requirement: Require-Bundle: org.eclipse.text; bundle-version="[3.6.0,4.0.0)"
    -> Bundle-SymbolicName: org.eclipse.text; bundle-version="3.10.100.v20200217-1239"
       org.eclipse.text [469]
         Unresolved requirement: Import-Package: com.ibm.icu.text

        at org.eclipse.osgi.container.Module.start(Module.java:462)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel$2.run(ModuleContainer.java:1844)
        at org.eclipse.osgi.internal.framework.EquinoxContainerAdaptor$1$1.execute(EquinoxContainerAdaptor.java:136)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1837)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1778)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1742)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1664)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:234)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:345)

See #1351

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@fbricon fbricon merged commit 0585be7 into eclipse-jdtls:master Feb 26, 2020
@fbricon
Copy link
Contributor

fbricon commented Feb 26, 2020

Thanks @Eskibear

@Eskibear Eskibear deleted the myMaster branch February 26, 2020 08:18
@fbricon fbricon added this to the Early March 2020 milestone Feb 26, 2020
@testforstephen
Copy link
Contributor

testforstephen commented Feb 26, 2020

See PR #1362, looks like com.ibm.icu is not required by the runtime any more, right? @fbricon

@fbricon
Copy link
Contributor

fbricon commented Feb 26, 2020

unfortunately, it's still required by platform and JDT. We just ensured it's not a direct dependency of jdt.ls, until the time both platform and jdt drop it too.

@testforstephen
Copy link
Contributor

ok, got that. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants