Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard the stale workingcopies that belonged to the deleted folder #1439

Merged
merged 1 commit into from
May 13, 2020

Conversation

testforstephen
Copy link
Contributor

Signed-off-by: Jinbo Wang jinbwan@microsoft.com

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@testforstephen
Copy link
Contributor Author

When renaming a package A to B, the received file events are like [ B: created, parent: changed, A: Deleted]. If there are sub files under package A being opened before, the working copies they produced are probably not released. One bad thing about these stale workingcopies is that they may produce some garbage diagnostics, because the publish diagnostics job in the DocumentLifeCycleHandler will iterate all workingcopies and report their diagnostics to client.

@fbricon fbricon added the bug label May 13, 2020
@fbricon fbricon added this to the Mid May 2020 milestone May 13, 2020
@fbricon fbricon merged commit 93d72c3 into eclipse-jdtls:master May 13, 2020
@fbricon
Copy link
Contributor

fbricon commented May 13, 2020

@testforstephen thanks!

@testforstephen testforstephen deleted the jinbo_renamefix branch May 13, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants