Send notification to the clients after importing projects #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
requested changes
May 29, 2020
| @@ -58,6 +58,14 @@ | |||
| @JsonNotification("language/actionableNotification") | |||
| void sendActionableNotification(ActionableNotification notification); | |||
|
|
|||
| /** | |||
| * The event notification is sent from a server to a client to tell the | |||
| * client that some certain events happen at server side, like: classpath updated. | |||
There was a problem hiding this comment.
The event notification is sent from a server to a client to notify the client certain events happened on the server side, eg. classpath was updated, projects were imported
| @@ -118,6 +123,9 @@ public IStatus runInWorkspace(IProgressMonitor monitor) throws CoreException { | |||
| } catch (CoreException e) { | |||
| return new Status(Status.ERROR, IConstants.PLUGIN_ID, "Importing projects failed.", e); | |||
| } | |||
| List<URI> projectUris = ProjectCommand.getAllJavaProjects(); | |||
There was a problem hiding this comment.
this doesn't include pom projects for instance
|
|
||
| public class ClasspathUpdateHandler implements IElementChangedListener { | ||
|
|
||
| public static final String CLASSPATH_UPDATED_NOTIFICATION = "__CLASSPATH_UPDATED__"; |
There was a problem hiding this comment.
I wonder if someone else will be broken by that
There was a problem hiding this comment.
Hmm, Not sure about that.
At least for the VS Code side, the client itself handles the logic of receiving the notification, the exposed event is still the same.
| @@ -165,6 +173,14 @@ public void sendActionableNotification(ActionableNotification notification) { | |||
| client.sendActionableNotification(notification); | |||
| } | |||
|
|
|||
| /** | |||
| * Send a notification to the client when some certain events happen. | |||
| * @See {@link org.eclipse.jdt.ls.core.internal.EventType} for all the event types. | |||
jdneo
force-pushed
the
cs/new-project-event
branch
from
a42228b
to
4916e5e
Compare
Signed-off-by: Sheng Chen <sheche@microsoft.com>
jdneo
force-pushed
the
cs/new-project-event
branch
from
4916e5e
to
ea561bd
Compare
snjeza
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require: redhat-developer/vscode-java#1476
Signed-off-by: Sheng Chen sheche@microsoft.com