Provide semantic tokens for class files #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 0dinD <zerodind@gmail.com>
|
@0dinD pretty cool! Do you think you could add a unit test though? |
|
@fbricon sure, I can look into adding a unit test. |
|
@0dinD I'm merging now because the change is safe to release, but please provide anti-regression tests as soon as you can. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple change, code-wise. But it allows the client of the language server to request semantic tokens not only for source files, but also for class files in libraries. This is done by using the preexisting
JDTUtils.resolveTypeRoot(String uri)method, which either resolves a source file or a class file into anITypeRootbased on the request protocol (file://...orjdt://...).