Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the 'java.import.gradle.java.home' preference #1512

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Expose the 'java.import.gradle.java.home' preference #1512

merged 1 commit into from
Jul 21, 2020

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Jul 21, 2020

@snjeza snjeza requested review from gorkem and fbricon July 21, 2020 20:10
@snjeza snjeza mentioned this pull request Jul 21, 2020
Merged
fbricon
fbricon requested changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@fbricon fbricon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpick, otherwise, LGTM

...dt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/GradlePreferenceChangeListener.java Outdated Show resolved Hide resolved
@fbricon fbricon added this to the End July 2020 milestone Jul 21, 2020
@snjeza
Expose the 'java.import.gradle.java.home' preference
82420e2 
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
@fbricon fbricon merged commit d2d7280 into eclipse-jdtls:master Jul 21, 2020
@fbricon
Copy link
Contributor

fbricon commented Jul 21, 2020

@snjeza thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon requested changes

@gorkem gorkem Awaiting requested review from gorkem

Assignees
No one assigned
Labels
enhancement gradle
Projects
None yet
Milestone
End July 2020
Development

Successfully merging this pull request may close these issues.

[doubt] Java 8, Java 11 and Gradle
2 participants
@snjeza @fbricon