Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use , as signature trigger char #1522

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Use , as signature trigger char #1522

merged 1 commit into from
Aug 10, 2020

Conversation

yyoncho
Copy link
Contributor

@yyoncho yyoncho commented Aug 1, 2020

This is what other servers(e. g. Rust Analyzer) do.

@eclipse-ls-bot
Copy link

Can one of the admins verify this patch?

@yyoncho
Use , as signature trigger char
a3a7f16 
This is what other servers do.

Signed-off-by: Ivan Yonchovski <yyoncho@gmail.com>
@testforstephen
Copy link
Contributor

add to whitelist

@fbricon fbricon changed the title Use , as signature trigger char Use , as signature trigger char Aug 10, 2020
@fbricon fbricon merged commit 5edcd0a into eclipse-jdtls:master Aug 10, 2020
@fbricon
Copy link
Contributor

fbricon commented Aug 10, 2020

Thanks @yyoncho!

@fbricon fbricon added this to the End August 2020 milestone Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement signature help
Projects
None yet
Milestone
End August 2020
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yyoncho @eclipse-ls-bot @testforstephen @fbricon