Initial implementation for code actions #155
Conversation
|
run tests |
gorkem
force-pushed
the
code_actions/initial
branch
from
1803a0c
to
14e0c4a
Compare
| params.setRange(range); | ||
| params.setContext(new CodeActionContext(Arrays.asList(getDiagnostic(Integer.toString(IProblem.UnusedImport), range)))); | ||
| List<? extends Command> commands = server.codeAction(params).join(); | ||
| Assert.assertFalse(commands.isEmpty()); |
There was a problem hiding this comment.
checking isEmpty is useless when checking the size on next line
| params.setRange(range); | ||
| params.setContext(new CodeActionContext(Arrays.asList(getDiagnostic(Integer.toString(IProblem.UnterminatedString), range)))); | ||
| List<? extends Command> commands = server.codeAction(params).join(); | ||
| Assert.assertFalse(commands.isEmpty()); |
There was a problem hiding this comment.
checking isEmpty is useless when checking the size on next line
| * | ||
| */ | ||
| @RunWith(MockitoJUnitRunner.class) | ||
| public class CodeActionHandlerTest extends AbstractCompletionBasedTest { |
There was a problem hiding this comment.
I'd probably make that class abstract and have separate test classes to check separate code actions
There was a problem hiding this comment.
What is the benefit?
There was a problem hiding this comment.
I'm expecting we'll see lots of different code actions, cramming everything under the same test class is gonna be messy
There was a problem hiding this comment.
A class per code actions is not less messy either. When we have a lot of code actions, we can think of a way to organize the tests. probably around common actions such as unused code etc.
gorkem
force-pushed
the
code_actions/initial
branch
from
14e0c4a
to
52e16d9
Compare
|
+1 to apply, once the conflict is resolved |
Implements “insert quotes” and remove import code actions. Lays the groundwork for more code actions. Signed-off-by: Gorkem Ercan <gorkem.ercan@gmail.com>
gorkem
force-pushed
the
code_actions/initial
branch
from
52e16d9
to
4094ddd
Compare
Add tests for the implemented code actions. Signed-off-by: Gorkem Ercan <gorkem.ercan@gmail.com>
gorkem
force-pushed
the
code_actions/initial
branch
from
4094ddd
to
991bcee
Compare
Implements “insert quotes” and remove import
code actions. Lays the groundwork for more
code actions.
Signed-off-by: Gorkem Ercan gorkem.ercan@gmail.com