Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed m2e 1.17 #1562

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Embed m2e 1.17 #1562

merged 1 commit into from
Oct 8, 2020

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Oct 8, 2020

m2e 1.17 now lazy loads a bunch of services, making its startup faster.
This helps jdt.ls shave a couple seconds off of its startup time as well.

Signed-off-by: Fred Bricon fbricon@gmail.com

Signed-off-by: Fred Bricon <fbricon@gmail.com>
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Everything passes for me locally. I can confirm that the m2e.core bundle start time gets reduced drastically.

@fbricon fbricon merged commit eba0282 into eclipse-jdtls:master Oct 8, 2020
@fbricon fbricon deleted the m2e-1.17 branch October 8, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants