Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java LS crashes on WSL Alpine #1612

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Java LS crashes on WSL Alpine #1612

merged 1 commit into from
Nov 27, 2020

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Nov 24, 2020

Fixes redhat-developer/vscode-java#1711

Signed-off-by: Snjezana Peco snjezana.peco@redhat.com

@snjeza
Java LS crashes on WSL Alpine
c2a0b01 
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
testforstephen
testforstephen approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works in macOS and WSL Alpine. The new approach can detect the parent process is terminated when i use kill -9 to force kill the parent VS Code process. Also no more "server restart" message when trying alpine.

@testforstephen testforstephen added this to the End November 2020 milestone Nov 27, 2020
@testforstephen testforstephen merged commit dc84198 into eclipse-jdtls:master Nov 27, 2020
@testforstephen
Copy link
Contributor

thanks @snjeza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testforstephen testforstephen testforstephen approved these changes

@gorkem gorkem Awaiting requested review from gorkem

@fbricon fbricon Awaiting requested review from fbricon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
End November 2020
Development

Successfully merging this pull request may close these issues.

LS fail in WSL Alpine due to "Connection to server got closed. Server will restart."
2 participants
@snjeza @testforstephen