Standard language server should also be able to exit on shutdown. #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "syntaxServerExitsOnShutdown" -> "shouldLanguageServerExitOnShutdown" - Shut down the standard language server on shutdown() similar to the syntax server, when "shouldLanguageServerExitOnShutdown" extended capability is enabled - Unlike the syntax server shutdown, the standard server has no issues if shutdown() returns to the client, before exit() completes Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard language server has the same issue the syntax server did. It doesn't exit immediately on shutdown request. It relies on the parent process watcher, but I believe that can take up to 30s in the worst case.
syntax server, when "shouldLanguageServerExitOnShutdown" extended
capability is enabled
if shutdown() returns to the client, before exit() completes
Signed-off-by: Roland Grunberg rgrunber@redhat.com