Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cannot exclude maven sub-module #1850

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Aug 20, 2021

fix redhat-developer/vscode-java#2075

This makes the following exclusion setting works:

    "**",
    "!**/module1/**"

For multi-module maven project, if user wants to ignore part of the sub-modules, he has to ignore the parent pom. Otherwise, the Maven Importer will collect all the sub modules if the parent pom is contained in the scanning result. More details can be seen in redhat-developer/vscode-java#2075.

Signed-off-by: Sheng Chen sheche@microsoft.com

Signed-off-by: Sheng Chen <sheche@microsoft.com>
@fbricon fbricon added the bug label Aug 20, 2021
@fbricon fbricon added this to the Mid September 2021 milestone Aug 20, 2021
@fbricon fbricon merged commit 9e31543 into eclipse-jdtls:master Aug 20, 2021
@jdneo jdneo deleted the cs/vscode-2075 branch August 21, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.project.exclusion is not working as expected
3 participants