Java LS sometimes hangs while loading a gradle project #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please |
Comment on lines
221
to
228
| try { | ||
| long start = System.currentTimeMillis(); | ||
| JavaLanguageServerPlugin.logInfo("Starting " + IMavenConstants.PLUGIN_ID); | ||
| Platform.getBundle(IMavenConstants.PLUGIN_ID).start(Bundle.START_TRANSIENT); | ||
| JavaLanguageServerPlugin.logInfo("Started " + IMavenConstants.PLUGIN_ID + " " + (System.currentTimeMillis() - start) + "ms"); | ||
| } catch (BundleException e) { | ||
| logException(e.getMessage(), e); | ||
| } |
There was a problem hiding this comment.
this code block can be extracted to a common method for reuse. e.g. void startBundle(String bundleName)
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
|
test this please |
testforstephen
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#2088
The issue happens when BuildSupportManager.obtainBuildSupports starts the m2e and buildship plugins that sometimes freezes the workspace.
A stack trace: redhat-developer/vscode-java#2088 (comment) and https://gist.github.com/snjeza/b02b8461499cf025a9b664442dd51ede
A solution is to start these plugins separately before initializing Java LS.
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com