Add semantic tokens for records and constructors #1897
Merged
+162
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 0dinD <zerodind@gmail.com>
|
Thanks @0dinD! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See redhat-developer/vscode-java#2124
See redhat-developer/vscode-java#2125
New semantic token types
record(Record Classes)recordComponent(Record Components)New semantic token modifiers
constructor(Constructors)methodtoclass,enum,recordetc.I also refactored the code for checking and setting the modifier bits, to make it more clear and concise. The reason for splitting it up into multiple different
check*methods is that we don't always need to check everything.CC: @Eskibear