Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude jdk.*, org.graalvm.* and io.micrometer.shaded.* from completion #1905

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Exclude jdk.*, org.graalvm.* and io.micrometer.shaded.* from completion #1905

merged 2 commits into from
Oct 13, 2021

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Oct 13, 2021 •
edited

... to align with default exclusions from Eclipse IDE

PR includes commit to fix #1904

@fbricon
Exclude jdk.*, org.graalvm.* and io.micrometer.shaded.* from completion
a11b856 
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon added this to the Mid October 2021 milestone Oct 13, 2021
@fbricon
Filter packages from completion
a2c3f4d 
Signed-off-by: Fred Bricon <fbricon@gmail.com>
rgrunber
rgrunber approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me with this change.

@rgrunber rgrunber merged commit d373ad9 into eclipse-jdtls:master Oct 13, 2021
@rgrunber rgrunber mentioned this pull request Oct 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

Assignees
No one assigned
Labels
content-assist enhancement
Projects
None yet
Milestone
Mid October 2021
Development

Successfully merging this pull request may close these issues.

packages are not filtered from completion despite the java.completion.filteredTypes configuration
2 participants
@fbricon @rgrunber