Add "Convert to Switch Expression" code assist proposal #1935
Conversation
|
In Eclipse, the quick fix doesn't apply to the whole source. I don't understand why they're not impacted the same way. |
|
As an update, I've found the set of API needed to have this apply to the statement on which code assist is activated, and not the entire file. Once the API is moved appropriately, we can make use of an I-build towards 2022-03 M1. For an explanation, there's usually 2 ways to implement these fixes on the Eclipse end.
Only the API for (2) was open, but it's easy enough to open (1). Upstream tracking bug : https://bugs.eclipse.org/bugs/show_bug.cgi?id=577540 |
rgrunber
force-pushed
the
convert-to-switch-expr
branch
from
61f33b2
to
5c35155
Compare
- Update target platform to 4.23 M1 build - o.e.core.net.linux & o.e.equinox.security.linux now provide support for all Linux architectures - Use upstream API to construct the code assist - Add test cases Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber
force-pushed
the
convert-to-switch-expr
branch
from
5c35155
to
f7d651f
Compare
|
Regarding the changes to org.eclipse.core.net.linux & org.eclipse.equinox.security.linux : https://bugs.eclipse.org/bugs/show_bug.cgi?id=577864 & https://bugs.eclipse.org/bugs/show_bug.cgi?id=577821 . These are in 4.23 M1. The umbrella bug seems to be https://bugs.eclipse.org/bugs/show_bug.cgi?id=566638 . |
Signed-off-by: Roland Grunberg rgrunber@redhat.com
There's a few issues that need to resolved regarding the API.
SwitchExpressionsFixCore.createCleanUp(CompilationUnit)but that will apply the fix to the entire source file, and we only want to apply it to the selected switch expression. To do that we need to open up the visibility of the constructor upstream.