Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show Organize imports in Quick Fixes for import declaration #1936

Merged
merged 4 commits into from
Nov 25, 2021

Conversation

CsCherrYY
Copy link
Contributor

@@ -157,18 +157,5 @@ public static void removeImportStatementProposals(IInvocationContext context, IP
JavaLanguageServerPlugin.log(e);
}
}

final ICompilationUnit cu= context.getCompilationUnit();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we remove this part since we will always show the quick fix.

Signed-off-by: Shi Chen <chenshi@microsoft.com>
Signed-off-by: Shi Chen <chenshi@microsoft.com>
Signed-off-by: Shi Chen <chenshi@microsoft.com>
@CsCherrYY CsCherrYY marked this pull request as ready for review November 24, 2021 08:52
Signed-off-by: Shi Chen <chenshi@microsoft.com>
Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@testforstephen testforstephen added this to the Late November milestone Nov 25, 2021
@testforstephen testforstephen merged commit 726ece1 into eclipse-jdtls:master Nov 25, 2021
@CsCherrYY CsCherrYY deleted the cs-organize-import branch June 30, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants