Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the order of code actions #2109

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

CsCherrYY
Copy link
Contributor

This PR introduces the sort mechanism in quick assists for different contexts, we can define different priorities for different contexts in QuickAssistComparator. e.g., in field declaration, generate accessor > generate constructor

sort.mp4

Signed-off-by: Shi Chen chenshi@microsoft.com

@CsCherrYY CsCherrYY marked this pull request as ready for review June 1, 2022 03:06
@CsCherrYY CsCherrYY marked this pull request as draft June 1, 2022 11:41
@CsCherrYY CsCherrYY marked this pull request as ready for review June 23, 2022 07:02
@CsCherrYY CsCherrYY changed the title Sort QuickAssists for different contexts Sort QuickAssists Jun 24, 2022
@CsCherrYY CsCherrYY changed the title Sort QuickAssists Reorder QuickAssists Jun 24, 2022
Signed-off-by: Shi Chen <chenshi@microsoft.com>
Signed-off-by: Shi Chen <chenshi@microsoft.com>
Signed-off-by: Shi Chen <chenshi@microsoft.com>
Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new order looks better.

Before:
image

After:
image

@testforstephen testforstephen changed the title Reorder QuickAssists Adjust the order of code actions Jun 29, 2022
@testforstephen testforstephen added this to the End June 2022 milestone Jun 29, 2022
@testforstephen testforstephen merged commit 498ee9f into eclipse-jdtls:master Jun 29, 2022
@CsCherrYY CsCherrYY deleted the cs-quickassist-sort branch June 30, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants