Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh the invisible project's classpath on demand #2160

Merged
merged 5 commits into from
Jul 20, 2022

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Jul 15, 2022

fix redhat-developer/vscode-java#1282

When user opens a source file, we try to infer the source root on demand if:

  • it's not the on the classpath
  • it has package not matching errors

Signed-off-by: Sheng Chen sheche@microsoft.com

- When user opens a source file, if it's not the on the classpath, or
  if it has package not matching errors, we try to infer the source root
  for it and fix the classpath.

Signed-off-by: Sheng Chen <sheche@microsoft.com>
Signed-off-by: Sheng Chen <sheche@microsoft.com>
Signed-off-by: sheche <sheche@microsoft.com>
Signed-off-by: sheche <sheche@microsoft.com>
Signed-off-by: sheche <sheche@microsoft.com>
Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdneo jdneo merged commit c6b8176 into eclipse-jdtls:master Jul 20, 2022
@jdneo jdneo deleted the cs/invisible-classpath branch July 20, 2022 05:41
@rgrunber rgrunber added this to the End July 2022 milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh the invisible project's classpath on-demand
3 participants