Automatically include the required plug-ins in the launch files #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdneo
approved these changes
Jul 18, 2022
|
With the option enabled, do we still need to list all the plugins under |
In theory, we can simplify these launch files further. Only need to add the initial plugins and let the PDE tools to calculate all required plugins for us. For now I'm just taking the minimal cost to enable it and unblock us, and I'll optimize it further in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing *.launch files are often broken while updating the target platform. We can mitigate this by adopting a new option to automatically include the required plugins while launching. This new option was introduced from Eclispe 2022-06
https://www.eclipse.org/eclipse/news/4.24/pde.php#auto-add-requirements-launches.