Fix type completion when type name conflicts #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When type completion are applied where the same simple name already imported in the scope, the second type completion is completed as a fully qualified completion.
|
Can one of the admins verify this patch? |
|
add to whitelist |
|
Do you mean in the below gif,
|
Yes in Eclipse when we have a Simple Name conflict, the fully qualified name is used as the completion text. |
|
You are welcome @jdneo |
jdneo
added a commit
to jdneo/eclipse.jdt.ls
that referenced
this pull request
Feb 10, 2023
- fix the performance downgrade introduced by eclipse-jdtls#2232. With that change, triggering completion via keyboard shortcut will take a long time. Now with the change, it will only do context sensitive import rewrite when resolving completion items. Signed-off-by: Sheng Chen <sheche@microsoft.com>
jdneo
added a commit
that referenced
this pull request
Feb 15, 2023
…ems (#2453) * Only do context sensitive import rewrite when resolving completion items - fix the performance downgrade introduced by #2232. With that change, triggering completion via keyboard shortcut will take a long time. Now with the change, it will only do context sensitive import rewrite when resolving completion items. --------- Signed-off-by: sheche <sheche@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When type completion are applied where the same simple name already imported in the scope, the second type completion is completed as a fully qualified completion.