Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signature help not working correctly for parameterized type #2293

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Oct 25, 2022

  • Get erased type name for parameterized type binding.
  • Try to search for secondary types when primary type search failed when resolving the method document.

fix redhat-developer/vscode-java#2739

Signed-off-by: Sheng Chen sheche@microsoft.com

- Get erased type name for parameterized type binding.
- Try to search for secondary types when primary type search failed when
  resolving the method document.

Signed-off-by: Sheng Chen <sheche@microsoft.com>
@rgrunber rgrunber merged commit 26d5d9f into eclipse-jdtls:master Oct 25, 2022
@rgrunber
Copy link
Contributor

Makes sense to me. The missing getErasure() seems to have been causing this, and it's definitely the right approach in getting rid of the generic type when searching.

@rgrunber rgrunber added this to the End October milestone Oct 25, 2022
@jdneo jdneo deleted the cs/issue-2739 branch October 26, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated. . .
3 participants