Configuring java project stuck in 69%

[snjeza]

Fixes redhat-developer/vscode-java#2763

Steps to reproduce:

• set

"java.import.generatesMetadataFilesAtProjectRoot": true,

in settings.json

$ git clone git@github.com:springframeworkguru/spring-rest-client-examples.git
$ cd spring-rest-client-examples
$ rm -rf ~/.config/Code/User/workspaceStorage/
$ rm -rf .project .classpath .settings/ .factorypath target/ .apt_generated*
$ code .

• wait for Java LS to build the workspace
• exit VS Code

$ rm -rf .project .classpath .settings/ .factorypath target/ .apt_generated*
$ code .

Test vsix: https://github.com/snjeza/vscode-test/raw/master/java-1.12.1.vsix

Signed-off-by: Snjezana Peco snjezana.peco@redhat.com

[jdneo]

I can repro the issue according to the given steps. And the fix seems working.

Something I'm interested in:

What will happen if we do not wait for the auto build off job?
Is this related with c141741?

[rgrunber]

re-test this please.

Change also works for me.

[snjeza]

Is this related with c141741?

No, it isn't.

What will happen if we do not wait for the auto build off job?

Java LS will freeze.

org.eclipse.jdt.apt.core.internal.generatedfile.GeneratedSourceFolderManager.removeFolder(GeneratedSourceFolderManager.java:508)

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=574227

[snjeza]

test this please

[jdneo]

@snjeza Thanks for the explanation. Maybe we can also add a comment to explain why we need to call ((Workspace) workspace).getBuildManager().waitForAutoBuildOff();?

[rgrunber]

Anytime we do such changes, it would be good to have a comment (ideally in the commit message body, or just referencing the bug in a comment) explaining why we do these changes. My only concern is that we never remove/undo one of the changes in order to fix another, which causes a regression.

[snjeza]

Maybe we can also add a comment to explain why we need to call ((Workspace) workspace).getBuildManager().waitForAutoBuildOff();?

@jdneo @rgrunber I have updated the PR.