set null analysis interactive by default
#2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shi Chen <chenshi@microsoft.com>
CsCherrYY
commented
Nov 9, 2022
| @@ -213,9 +213,6 @@ public void triggerInitialization(Collection<IPath> roots) { | |||
| JavaLanguageServerPlugin.logInfo("ProjectRegistryRefreshJob finished " + (System.currentTimeMillis() - start) + "ms"); | |||
| // load gradle plugin https://github.com/redhat-developer/vscode-java/issues/2088 | |||
| startBundle(CorePlugin.PLUGIN_ID); | |||
| start = System.currentTimeMillis(); | |||
There was a problem hiding this comment.
I found the wait part comes from #1874, since the LoadingGradleVersionJob will be no longer conflicting via eclipse/buildship@2d10573, @snjeza can we move this part? Or am I missing something here? It would be great if there is a way to test this.
There was a problem hiding this comment.
@CsCherrYY I think we can. I can't reproduce the issue described at redhat-developer/vscode-java#2088 (comment) with your patch.
I'm not sure how to create a test for it. The issue happened randomly when Java LS tarted.
snjeza
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shi Chen chenshi@microsoft.com
related to redhat-developer/vscode-java#2790
Since the deadlock issue has been addressed via eclipse/buildship@2d10573, we can get the new buildship snapshot without deadlock, so we can set
interactiveby default now.